rtyler
03/28/2023, 4:27 AMOptimizeBuilder
tonight, and I'm curious why with_filters
takes PartitionFilter<&'a, &'a str>
where T = &'a str
rather than an allocated `String? Lifetimes are not my strength but I'm not sure how it would be possible to create PartitionFilter
with anything other than static strings for the partition values. I have tried a couple different options with no success, and I think the T
used for PartitionFIlter
is just too restrictive ๐คRobert
03/28/2023, 4:29 AMrtyler
03/28/2023, 4:30 AMgit-annotate(1)
because you moved the code, not because you wrote it ๐Robert
03/28/2023, 4:32 AMrtyler
03/28/2023, 4:33 AMPartitionFilter
isn't too awkward, the lifetime constraints are a little odd. I'll experiment with OptimizeBuilder
and just a different T
Robert
03/28/2023, 4:43 AMWill Jones
03/28/2023, 2:43 PMrtyler
03/31/2023, 4:23 PMPartitionFilter
with some changes and it got messy really quick, so I just hacked around the lifetime issue a bit: https://github.com/buoyant-data/lambda-delta-optimize/blob/main/src/main.rs#L37-L53
๐