https://delta.io logo
w

Will Jones

03/12/2023, 2:17 AM
Saw this collection of CI scripts last night: https://github.com/jonhoo/rust-ci-conf Explained at the beginning of this stream:

https://www.youtube.com/watch?v=xUH-4y92jPg

The one that stood out to me for our project was the minimal version test (
-Zminimal-versions
or probably better with the upcoming
-Zdirect-minimal-versions
). That might allow us to be more flexible with our Arrow dependency so we could for example support a range like
arrow >= 30, <= 32
. Datafusion probably has more frequent breaking changes in it’s API, but maybe as it gets more stable we could support a wider range for that too.
👍 3
Probably more controversial, but he did also lay out the argument for why we should consider checking in
Cargo.lock
even in a library project: it makes it much easier to do
git bisect
if every version already has a valid environment already solved. And you can always maintain a CI job that makes sure it complies without it.
d

Denny Lee

03/12/2023, 5:47 PM
I guess from the standpoint that we’re an end product it also makes sense for us to include cargo.lock?
2 Views