https://delta.io logo
r

Robert

01/12/2023, 11:37 PM
Probably obvious to most folks here, but I just stumbled across
cargo clippy --fix
, and I like it 😄.
🎉 1
w

Will Jones

01/12/2023, 11:38 PM
🤯
I’ve been avoiding running clippy on the tests because there are so many failures
😂 1
but if that works…
Or I thought there were more failures, now I’m not getting them…
r

Robert

01/12/2023, 11:45 PM
I’getting a couple of fixes in the tests …
Copy code
Checking dynamodb_lock v0.4.2 (/Users/packre/code/delta-rs/dynamodb_lock)
       Fixed rust/tests/integration_object_store.rs (2 fixes)
       Fixed rust/src/operations/transaction.rs (1 fix)
       Fixed rust/tests/integration_concurrent_writes.rs (3 fixes)
       Fixed rust/tests/fs_common/mod.rs (1 fix)
       Fixed rust/tests/checkpoint_writer.rs (1 fix)
warning: `assert!(true)` will be optimized out by the compiler
   --> rust/tests/integration_commit.rs:149:17
    |
149 |                 assert!(true, "Delta version already exists.");
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: remove it
    = help: for further information visit <https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants>
    = note: `#[warn(clippy::assertions_on_constants)]` on by default

warning: `assert!(false, ..)` should probably be replaced
   --> rust/tests/integration_commit.rs:152:17
    |
152 |                 assert!(false, "Delta version should already exist.");
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use `panic!(..)` or `unreachable!(..)`
    = help: for further information visit <https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants>

warning: `deltalake` (test "integration_commit") generated 2 warnings
       Fixed rust/tests/integration_read.rs (3 fixes)
       Fixed rust/tests/add_actions_test.rs (5 fixes)
    Finished dev [unoptimized + debuginfo] target(s) in 46.58s
4 Views