https://delta.io logo
s

shingo

04/18/2023, 6:40 AM
Hi everyone, I'm currently working on a code snippet to demonstrate the basics of Delta Sharing. While working on this, I came across the following implementations: ā€¢ https://github.com/delta-io/delta-sharing/blob/7f0126073db3bf26c29648687c996db20e1b64b5/python/delta_sharing/__init__.py#L23 ā€¢ https://github.com/delta-io/delta-sharing/blob/7f0126073db3bf26c29648687c996db20e1b64b5/python/delta_sharing/delta_sharing.py#L54 ā€¢ https://github.com/delta-io/delta-sharing/blob/7f0126073db3bf26c29648687c996db20e1b64b5/python/delta_sharing/rest_client.py#L271 After reviewing these implementations, it seems that the Python client library does not consider the JSON predicates public. I would like to demonstrate this functionality, but should I implement my own API by adding
predicateHints
parameter to load_as_pandas for now? Thanks.
I will make an issue to ask the developers if this feature is necessary or not on GitHub. Thanks in advance.
j

Jim Hibbard

04/18/2023, 4:31 PM
Hi Shingo! I'd definitely open up a feature request. After scanning the code I think you're correct. Since the
load_as_pandas
function uses the DeltaSharingReader it just needs a variable added to pass the JSON predicate hints. Excellent catch! I'd even suggest submitting the pull request with the change. Let me know if you want any help doing that. It'd be a great contribution šŸŽ‰
šŸ‘ 1
s

shingo

04/18/2023, 5:05 PM
Thanks, @Jim Hibbard ! I already made an issue on [GitHub](https://github.com/delta-io/delta-sharing/issues/292). As you suggested, I will make a pull request as well after reading the contribution guideline!
delta io 1
šŸ™Œ 1
j

Jim Hibbard

04/18/2023, 5:51 PM
Awesome, thanks Shingo! Would you be interested in doing a small post to highlight this addition on LinkedIn once it goes through? I think this is a feature people will want to know about :D
šŸ‘ 1
59 Views