https://delta.io logo
r

rtyler

04/28/2023, 3:24 PM
@Will Jones the commit rules totally get screwy with links "βœ–οΈ body's lines must not be longer than 100 characters [body-max-line-length]" Can you disable this check?
w

Will Jones

04/28/2023, 3:25 PM
Good to know. I’ll look into that
r

rtyler

04/28/2023, 3:27 PM
I am attempting to fix up the python bindings for arrow 37, but I may need to appeal for help there too, I don't spend any time over there πŸ˜›
@Will Jones Do you have a quick 15-30min to convert this field data type conversion stuff in
python/src/schema.rs
? I don't fully understand this code? If not, I can probably brute force it later tonight after work if my brain still works. πŸ˜•
I made the simple changes
w

Will Jones

04/28/2023, 3:44 PM
I can take a look later today
πŸ‘ 1
r

rtyler

04/28/2023, 8:12 PM
@Will Jones I got it knocked out on my lunch break πŸ˜† pushing changes once the compile finishes and then we should be ready to review
πŸ‘ 1
OHNOES, what compiled before now fails that everything is updated! some of these field mutations have to be handled differently with 37 because of the move from Field to FieldRef in a lot of APIs
bugger
@Will Jones do you happen to know how
convert_to_large_type
is getting away with the `with_data_type` invocation without a
mut
modifier??
with_data_type does take a
mut self
but I'm confused by no
mut
coming in from our code here πŸ˜•
w

Will Jones

04/28/2023, 8:30 PM
Not sure I understand the issue; it is taking an owned value
might need to deref and clone the fieldref if you want to get an owned field
r

rtyler

04/28/2023, 8:37 PM
ahhhhhhhhhhhh right, I've been doing so much Arc nonsense the last couple days I wasnm't even thinking that with_data_type was taking ownership
I'm so used to Arc and
&mut
πŸ˜†
w

Will Jones

04/29/2023, 12:20 AM
Well this is dumb. There doesn’t seem to be an easy way to disable it 😞 https://github.com/conventional-changelog/commitlint/issues/2930
πŸ€” 1
actually maybe I can
r

rtyler

04/29/2023, 4:44 AM
@Will Jones looks like we're ready to roll, thanks for the assist! https://github.com/delta-io/delta-rs/pull/1314
w

Will Jones

04/30/2023, 5:57 PM