https://delta.io logo
r

rtyler

07/19/2023, 6:24 AM
@Robert hoping you're awake and available, I just got to https://github.com/delta-io/delta-rs/pull/1544 and would like your 👍 to merge this and cut a release. I don't know why I clicked the merge button on 1498, I must have been too sleep deprived 🙂
r

Robert

07/19/2023, 6:26 AM
I must have been too sleep deprived 🙂
I know the feeling 😄. Approved the PR!
👍 1
r

rtyler

07/19/2023, 6:27 AM
important to clean up one's own messes, will cut a release as soon as the auto-merge fires
💪 1
AH! I found the problem here. I have been using "auto-merge" more frequently lately. But our GitHub configuration does not require all the existing status checks to pass in order to have a pull request merged. This means that auto-merge was seeing the following checks go and said "great, merge!" Just happened on that pull request with the integration tests! I'm going to update the branch protection rule now and sort out what's going on in
main
after that 😒
Unfortunately it doesn't look like there's any way to say "require all the status checks that exist in `main`" in the repo settings, which means this list must be manually updated and managed 😠
r

Robert

07/19/2023, 6:49 AM
That seems like a reasonable feature expect given the intent behind checks 😄