https://delta.io logo
c

Cole MacKenzie

07/31/2023, 5:30 PM
Oh, and if possible, could
rust-0.14.0
be cut today ๐Ÿ˜„
r

rtyler

07/31/2023, 5:37 PM
anything is possible ๐Ÿ˜›
๐Ÿ™Œ 1
what are you keen on getting out the door?
c

Cole MacKenzie

07/31/2023, 5:37 PM
Datafusion and arrow upgrades. There was a regression in previous arrow that broke reading parquet with nulls ๐Ÿ˜จ
โž• 2
r

rtyler

07/31/2023, 5:38 PM
i see, womp womp
psssst something landed on crates.io yesterday
๐Ÿ™Œ 1
c

Cole MacKenzie

08/01/2023, 4:28 PM
๐Ÿคจ ๐Ÿ‘€
Thanks @rtyler!
Is it possible to generate the release notes too? ๐Ÿ˜…
r

rtyler

08/01/2023, 5:00 PM
so needy
you could generate them too ๐Ÿ˜‰
c

Cole MacKenzie

08/01/2023, 5:01 PM
Lol I'll admit I tried it but the script complains about me not having a token
r

rtyler

08/01/2023, 5:21 PM
just give it a github token ๐Ÿ™‚
c

Cole MacKenzie

08/01/2023, 5:25 PM
Oh, lol
@rtyler is there anything different about how
0.14
was published or tagged? If you try to fetch it using Rust 1.70.0, it fails
Copy code
cargo +1.70.0 update 
    Updating <http://crates.io|crates.io> index
    Updating git repository `<https://github.com/delta-io/delta-rs.git>`
error: no matching package named `deltalake` found
location searched: <https://github.com/delta-io/delta-rs.git?tag=rust-v0.14.0>
r

rtyler

08/01/2023, 9:20 PM
๐Ÿค”
I'm not sure, I see it legitimately published to crates.io ๐Ÿ˜•
c

Cole MacKenzie

08/01/2023, 9:21 PM
Yeah, I am confused. I tried pinning the tag and rev to github repo. They both fail like that on 1.70.
using
deltalake = { version = "0.14.0" }
works tho
but
git
defs fail
r

rtyler

08/01/2023, 9:27 PM
is there a particular reason you're using 1.71 versus 1.70? I'm wondering if some Cargo change with the workspace configuration: https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-171-2023-07-13
c

Cole MacKenzie

08/01/2023, 9:28 PM
Yeah, our internal CI hasn't been updated to 1.71 yet AFAIK
r

rtyler

08/01/2023, 9:28 PM
ah
c

Cole MacKenzie

08/01/2023, 9:29 PM
Whelp, guess that's what I am going to do this afternoon ๐Ÿ˜
r

rtyler

08/01/2023, 9:30 PM
can you at least verify that the behavior works on 1.71 that you would expect? I wouldn't have thought the cargo changes would affect end users in any way
c

Cole MacKenzie

08/01/2023, 9:32 PM
Copy code
$ cargo +1.70.0 update 
error: no matching package named `deltalake` found
location searched: <https://github.com/delta-io/delta-rs.git?tag=rust-v0.14.0>
$ cargo +1.71.0 update
    Updating <http://crates.io|crates.io> index
    Updating git repository `<https://github.com/delta-io/delta-rs.git>`
Works fine on 1.71
r

rtyler

08/01/2023, 9:32 PM
image.png
๐Ÿฆ€ 1
@Cole MacKenzie can you drop some details into a github issue? I'm worried that we might have to backout that helpful workspace change ๐Ÿ˜ฟ
c

Cole MacKenzie

08/01/2023, 9:33 PM
๐Ÿ˜จ ๐Ÿ˜ข
Sure, let me gather some details
I wonder if declaring
[workspace.package]
in root
Cargo.toml
is the "fix"?