https://delta.io logo
h

Hugo Saavedra

08/01/2023, 5:19 PM
looking at the
delta_log_schema_for_table
function in
<http://delta_arrow.rs|delta_arrow.rs>
and finding it a little tricky to keep track of all the nesting here would there be any value/improvement in readability to be gained if I were to add some helper methods here? or would it be better to avoid the extra indirection/overhead? https://github.com/delta-io/delta-rs/blob/2f9a67f79f3d06367108925424609dfa1d24786e/rust/src/delta_arrow.rs#L310
I ended up putting together a pr for this anyway. Not sure how welcome/worthwhile refactors like this are given that recent work is mostly on
delta-kernel
w

Will Jones

08/15/2023, 8:15 PM
Thanks for doing that. I think it's interesting to do; it might be something we even want to see if we can upstream to arrow-rs. I was prototyping something similar for making it easier to write record batches
👀 1