https://delta.io logo
c

Cole MacKenzie

09/08/2023, 6:36 PM
the aforementioned panic,
Copy code
running 1 test
thread 'local::test_issue_parquet_bit_util' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', /Users/cole/.cargo/registry/src/index.crates.io-6f17d22bba15001f/parquet-45.0.0/src/util/bit_util.rs:272:9
w

Will Jones

09/08/2023, 6:41 PM
You writing from Rust?
I think there is a roundtrip test for Python, but might not be one for Rust
In which case this might not be right for Rust
c

Cole MacKenzie

09/08/2023, 6:44 PM
Yeah, writing from Rust using JsonWriter
Looks like there is a
new_map
function we could use too, https://github.com/apache/arrow-rs/blob/master/arrow-schema/src/field.rs#L230
Which also sets it to false
Anyway, I have a repro test case made. I'll file the issue and then the fix
w

Will Jones

09/08/2023, 6:54 PM
Sounds good. Thanks for pointing that out
c

Cole MacKenzie

09/08/2023, 7:14 PM
could you kick the CI so it starts? https://github.com/delta-io/delta-rs/pull/1620 I think there is one test failing, but not sure if its just me or not
Thanks @Will Jones! I'll check back after lunch 😋
👍 1
@Will Jones, any idea where that outer
nullable: true
is coming from on that
Map
?
I think it comes from here, https://github.com/delta-io/delta-rs/blob/main/rust/src/delta_arrow.rs#L42 Not sure if this function should be a
match
on type, or something else
Thanks for your help on this @Will Jones 🙏
👍 1